kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-11-12 20:15:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(session): correct stale pool-size comment

Browse Source 
pool_max_idle_per_host no longer matches the downloader worker cap;
POOL_MAX_SIZE was deliberately raised above it so hedge racers and
tail-boost parts do not park threads under pool_block=True. Point the
comment at the constant so the value is not reverted to the worker cap.
This commit is contained in:
imSp4rky
2026-08-07 11:36:31 -06:00
parent 431aa8fa54
commit d91159fb37
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unshackle/core/session.py
+3 -2
View File
@@ -839,8 +839,9 @@ def session(
# Connection-pool / timeout defaults applied only when neither config.network nor the caller set them.
# connect_timeout + read_timeout mirror the requests-path default timeout (CONNECT_TIMEOUT, READ_TIMEOUT)
# so an unset config still gets a bounded connect and read like requests; pool_idle_timeout stays under
# the typical ~60s CDN idle kill; pool_max_idle_per_host matches the downloader worker cap to avoid
# HTTP/1.1 connection churn; tcp_keepalive keeps long idle segments warm.
# the typical ~60s CDN idle kill; pool_max_idle_per_host follows POOL_MAX_SIZE, sized above the worker
# cap because hedge racers and tail-boost parts push in-flight requests past it (see POOL_MAX_SIZE);
# tcp_keepalive keeps long idle segments warm.
session_kwargs.setdefault("connect_timeout", CONNECT_TIMEOUT)
session_kwargs.setdefault("read_timeout", READ_TIMEOUT)
session_kwargs.setdefault("pool_idle_timeout", 55)