fix(tools): pass -nostdin to all ffmpeg calls

When ffmpeg runs with the terminal on stdin it turns off echo for its
interactive keys. If several run at once, or one gets killed, echo never
comes back and the terminal is left broken after dl exits.

unshackle/commands/util.py

@@ -135,7 +135,19 @@ def crop(path: Path, aspect: str, letter: bool, offset: int, preview: bool) -> N
             ]
 
         ffmpeg_call = subprocess.Popen(
-            [binaries.FFMPEG, "-y", "-i", str(video_path), "-map", "0:v:0", "-c", "copy", "-bsf:v", crop_filter]
+            [
+                binaries.FFMPEG,
+                "-nostdin",
+                "-y",
+                "-i",
+                str(video_path),
+                "-map",
+                "0:v:0",
+                "-c",
+                "copy",
+                "-bsf:v",
+                crop_filter,
+            ]
             + out_path,
             stdout=subprocess.PIPE,
         )
@@ -216,6 +228,7 @@ def range_(path: Path, full: bool, preview: bool) -> None:
         ffmpeg_call = subprocess.Popen(
             [
                 binaries.FFMPEG,
+                "-nostdin",
                 "-y",
                 "-i",
                 str(video_path),
@@ -267,6 +280,7 @@ def test(path: Path, map_: str) -> None:
         p = subprocess.Popen(
             [
                 binaries.FFMPEG,
+                "-nostdin",
                 "-hide_banner",
                 "-benchmark",
                 "-err_detect",

unshackle/core/manifests/hls.py

@@ -1074,6 +1074,7 @@ class HLS:
                 subprocess.check_call(
                     [
                         binaries.FFMPEG,
+                        "-nostdin",
                         "-hide_banner",
                         "-loglevel",
                         "error",

unshackle/core/tracks/track.py

@@ -921,6 +921,7 @@ class Track:
         def _ffmpeg(extra_args: list[str] = None, bsf: Optional[str] = None):
             args = [
                 binaries.FFMPEG,
+                "-nostdin",
                 "-hide_banner",
                 "-loglevel",
                 "error",

unshackle/core/tracks/video.py

@@ -385,6 +385,7 @@ class Video(Track):
         subprocess.run(
             [
                 binaries.FFMPEG,
+                "-nostdin",
                 "-hide_banner",
                 "-loglevel",
                 "panic",
@@ -493,6 +494,7 @@ class Video(Track):
             subprocess.run(
                 [
                     binaries.FFMPEG,
+                    "-nostdin",
                     "-hide_banner",
                     "-loglevel",
                     "error",
@@ -667,6 +669,7 @@ class Video(Track):
         subprocess.run(
             [
                 binaries.FFMPEG,
+                "-nostdin",
                 "-hide_banner",
                 "-loglevel",
                 "panic",