From af46dd5fc9b0635c26e73b34e3c9de4d67b3d614 Mon Sep 17 00:00:00 2001 From: imSp4rky Date: Thu, 9 Jul 2026 22:49:32 -0600 Subject: [PATCH] fix(tracks): treat ccextractor signal-crash as non-fatal A crash (negative return code, e.g. SIGABRT) during best-effort CC extraction now logs a warning instead of aborting a completed download. --- unshackle/core/tracks/video.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/unshackle/core/tracks/video.py b/unshackle/core/tracks/video.py index db9d17e1..a3804a41 100644 --- a/unshackle/core/tracks/video.py +++ b/unshackle/core/tracks/video.py @@ -543,6 +543,11 @@ class Video(Track): e.returncode, duration_ms=round((time.monotonic() - cc_start) * 1000, 1), ) + if e.returncode < 0: + logging.getLogger("Video").warning( + f"ccextractor crashed (signal {-e.returncode}) on {self.path.name}; skipping CC extraction" + ) + return out_path.exists() if e.returncode != 10: # 10 = No captions found raise return out_path.exists()