unshackle-dl/unshackle
1
0
Fork 0
forked from kenzuya/unshackle
Code Pull Requests 1 Activity

fix(tracks): close temp session and improve path type error

Browse Source
This commit is contained in:
Andy
2026-02-08 20:04:22 -07:00
parent c5b063391c
commit 29a697a8e7
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
unshackle/core/tracks/attachment.py
View File

@@ -65,9 +65,13 @@ class Attachment:
path = None path = None
else: else:
try: try:
session = session or requests.Session() if session is None:
response = session.get(url, stream=True) with requests.Session() as session:
response.raise_for_status() response = session.get(url, stream=True)
response.raise_for_status()
else:
response = session.get(url, stream=True)
response.raise_for_status()
config.directories.temp.mkdir(parents=True, exist_ok=True) config.directories.temp.mkdir(parents=True, exist_ok=True)
download_path.parent.mkdir(parents=True, exist_ok=True) download_path.parent.mkdir(parents=True, exist_ok=True)
@@ -80,7 +84,9 @@ class Attachment:
raise ValueError(f"Failed to download attachment from URL: {e}") raise ValueError(f"Failed to download attachment from URL: {e}")
if path is not None and not isinstance(path, (str, Path)): if path is not None and not isinstance(path, (str, Path)):
raise ValueError("The attachment path must be provided.") raise ValueError(
f"Invalid attachment path type: expected str or Path, got {type(path).__name__}."
)
if path is not None: if path is not None:
path = Path(path) path = Path(path)