kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-06-10 11:12:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: use plain hyphens instead of em-dashes in comments

Browse Source
This commit is contained in:
Avi Cohen
2026-06-05 18:25:14 +03:00
parent 41fef5d33a
commit 73d2cbccf8
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/tracks/test_subtitle_skip.py
View File

@@ -1,4 +1,4 @@
"""Tests for ``download_tracks_in_passes`` — the two-pass track download used by """Tests for ``download_tracks_in_passes`` - the two-pass track download used by
``dl.result()`` when ``--skip-subtitle-errors`` is set. ``dl.result()`` when ``--skip-subtitle-errors`` is set.
The behaviour under test is the cancel-event interaction: a failed track sets the The behaviour under test is the cancel-event interaction: a failed track sets the
@@ -54,7 +54,7 @@ class Harness:
``run_one`` mirrors ``Track.download``: it early-returns (without recording a ``run_one`` mirrors ``Track.download``: it early-returns (without recording a
completion) when the cancel event is already set, and a track flagged to fail completion) when the cancel event is already set, and a track flagged to fail
sets the event and raises — exactly what the real cancel sites do. sets the event and raises - exactly what the real cancel sites do.
""" """
def __init__(self, fail_ids: set[str]): def __init__(self, fail_ids: set[str]):

2
unshackle/commands/dl.py
View File

@@ -74,7 +74,7 @@ def download_tracks_in_passes(tracks, max_concurrent, run_one, *, skip_subtitle_
"""Download a title's tracks, keeping a skippable subtitle failure from corrupting the rest. """Download a title's tracks, keeping a skippable subtitle failure from corrupting the rest.
A failed track sets the process-global ``DOWNLOAD_CANCELLED`` event, which makes other A failed track sets the process-global ``DOWNLOAD_CANCELLED`` event, which makes other
in-flight tracks early-return without raising — so catching a subtitle failure after the fact in-flight tracks early-return without raising - so catching a subtitle failure after the fact
can leave a half-downloaded video/audio that still gets muxed. When ``skip_subtitle_errors`` can leave a half-downloaded video/audio that still gets muxed. When ``skip_subtitle_errors``
is set the fatal tracks (video/audio) are therefore downloaded concurrently first, and the is set the fatal tracks (video/audio) are therefore downloaded concurrently first, and the
skippable subtitles run in a separate sequential pass once nothing else is in flight, with the skippable subtitles run in a separate sequential pass once nothing else is in flight, with the