kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-11-12 12:05:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): check and cast download job service options like a session does

Browse Source 
A bad value now gets 400 INVALID_PARAMETERS at submit and the worker casts each option; a flat dl key such as quality or lang no longer fills a service option of the same name.
This commit is contained in:
imSp4rky
2026-11-01 20:21:42 -07:00
parent de9646dba2
commit 65c8e60a7a
6 changed files with 130 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/dev/rest-api/endpoints.md
+4 -2
View File
@@ -492,9 +492,11 @@ Make a download job. It requires `service` and `title_id`. Every other field is
**Service options.** A service's own CLI options travel in the same body. Send them in a nested
`service_params` object, or as flat top-level keys. When the body has `service_params`, the server
reads service options only from it, and every flat key is a `dl` value. An option you leave out
reads service options only from it, and every flat key is a `dl` value. Without it, a flat key that
is also a `dl` option, such as `quality` or `lang`, stays a `dl` value. An option you leave out
takes the default declared on the service's `cli` command, so the job matches the equivalent `dl`
run. `profile` at the top level always means the credential
run. The server checks each service option against that option's type, and a value it refuses gets
`400 INVALID_PARAMETERS`. `profile` at the top level always means the credential
profile, never a service's own `--profile` option.
=== "Request"