refactor(remote)!: send service options only in service_params

A service option named like a dl option (e.g. --profile) is no longer dropped or mixed with the dl value; the server casts nested values and keeps cli defaults nested.
This commit is contained in:
imSp4rky
2026-10-30 16:16:56 -06:00
parent 47f88b1b65
commit 5206b3cab6
12 changed files with 139 additions and 71 deletions
@@ -645,9 +645,15 @@ def test_dl_selection_travels_nested_and_a_service_option_cannot_override_it() -
"forced_subs": True,
"exact_lang": True,
}
assert data["lang"] == 3
assert "lang" not in data and "a_lang" not in data
assert data["service_params"] == {"lang": 3, "a_lang": "x"}
def test_a_service_profile_option_travels_nested_and_keeps_the_credential_profile() -> None:
data = _sent_create_data({"profile": "work"}, {"profile": "QC"})
assert data["profile"] == "work"
assert data["service_params"] == {"profile": "QC"}
def test_no_dl_params_when_the_ctx_has_no_selection() -> None:
assert "dl_params" not in _sent_create_data({}, {})