kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-11-15 05:25:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(remote)!: send service options only in service_params

Browse Source 
A service option named like a dl option (e.g. --profile) is no longer dropped or mixed with the dl value; the server casts nested values and keeps cli defaults nested.
This commit is contained in:
imSp4rky
2026-10-30 16:16:56 -06:00
parent 47f88b1b65
commit 5206b3cab6
12 changed files with 139 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/remote/unit/test_remote_relay.py
+6
View File
@@ -136,6 +136,12 @@ def test_make_remote_service_passes_only_cli_options(remote_config, monkeypatch)
assert built["args"][5]["EXAMPLE"] == {"x": 1}
def test_a_service_option_named_like_a_dl_value_passes_only_nested():
info = {"cli_params": [{"kind": "option", "name": "profile"}]}
assert remote_service.remote_service_params(info, {"service_params": {"profile": "QC"}}) == {"profile": "QC"}
assert remote_service.remote_service_params(info, {"profile": "QC"}) == {}
def test_remote_error_carries_its_reason_and_exits_a_cli_run():
err = remote_service.RemoteError("Server error [SESSION_NOT_FOUND]: gone", "SESSION_NOT_FOUND")
assert isinstance(err, SystemExit) and err.code == 1 and err.kind == "SESSION_NOT_FOUND"