kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-05-17 06:09:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tags): prevent metadata lookup failures from skipping group tag

Browse Source 
Wrapped metadata provider lookup in try/except so custom tags (Group) are always applied even when IMDB/TMDB lookups fail. Also log mkvpropedit errors instead of silently discarding them.
This commit is contained in:
imSp4rky
2026-04-12 22:21:02 +00:00
parent 2e7fc1720d
commit 4179b9045e
1 changed files with 43 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
unshackle/core/utils/tags.py
View File

@@ -33,12 +33,15 @@ def apply_tags(path: Path, tags: dict[str, str]) -> None:
f.write("\n".join(xml_lines)) f.write("\n".join(xml_lines))
tmp_path = Path(f.name) tmp_path = Path(f.name)
try: try:
subprocess.run( result = subprocess.run(
[str(binaries.Mkvpropedit), str(path), "--tags", f"global:{tmp_path}"], [str(binaries.Mkvpropedit), str(path), "--tags", f"global:{tmp_path}"],
check=False, check=False,
stdout=subprocess.DEVNULL, capture_output=True,
stderr=subprocess.DEVNULL, text=True,
) )
if result.returncode != 0:
log.warning("mkvpropedit failed (exit %d): %s", result.returncode, result.stderr.strip())
else:
log.debug("Tags applied via mkvpropedit") log.debug("Tags applied via mkvpropedit")
finally: finally:
tmp_path.unlink(missing_ok=True) tmp_path.unlink(missing_ok=True)
@@ -92,6 +95,7 @@ def tag_file(
standard_tags: dict[str, str] = {} standard_tags: dict[str, str] = {}
if config.tag_imdb_tmdb: if config.tag_imdb_tmdb:
try:
providers = get_available_providers() providers = get_available_providers()
if not providers: if not providers:
log.debug("No metadata providers available; skipping tag lookup") log.debug("No metadata providers available; skipping tag lookup")
@@ -129,6 +133,8 @@ def tag_file(
if result and result.external_ids: if result and result.external_ids:
standard_tags = _build_tags_from_ids(result.external_ids, kind) standard_tags = _build_tags_from_ids(result.external_ids, kind)
except Exception as e:
log.warning("Metadata lookup failed, applying custom tags only: %s", e)
apply_tags(path, {**custom_tags, **standard_tags}) apply_tags(path, {**custom_tags, **standard_tags})