fix(api): validate quality and bitrate params like dl and pass cdm_only to services

Reject bad quality, bitrate/range conflicts and malformed ranges with a 400, convert quality in the worker, and pass cdm_only into ctx.params.

tests/remote/unit/test_api_quality_param.py

@@ -0,0 +1,50 @@
+"""The REST download path converts ``quality`` and passes ``cdm_only`` like the CLI."""
+
+from __future__ import annotations
+
+from pathlib import Path
+from typing import Any
+
+import click
+import pytest
+
+import unshackle.commands.dl as dl_module
+from unshackle.core.api import download_manager, handlers
+from unshackle.core.api.handlers import validate_download_parameters
+from unshackle.core.services import Services
+
+pytestmark = pytest.mark.unit
+
+
+class _Captured(Exception):
+    pass
+
+
+@pytest.mark.parametrize("quality", ["1080p", ["1080"], [1080, 720], "1080,720"])
+def test_the_api_accepts_the_quality_forms_the_cli_accepts(quality: Any) -> None:
+    assert validate_download_parameters({"quality": quality}) is None
+
+
+def test_a_rest_job_converts_quality_and_passes_cdm_only(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
+    class FakeDl:
+        cli = click.Command("dl")
+
+        def __init__(self, ctx: click.Context, **kwargs: object) -> None:
+            self.ctx = ctx
+
+        def result(self, **kwargs: object) -> None:
+            raise _Captured(self.ctx.params["quality"], kwargs["quality"], self.ctx.params["cdm_only"])
+
+    class FakeService:
+        def __init__(self, ctx: click.Context) -> None:
+            pass
+
+    monkeypatch.setattr(dl_module, "dl", FakeDl)
+    monkeypatch.setattr(Services, "get_path", staticmethod(lambda s: tmp_path))
+    monkeypatch.setattr(Services, "load", staticmethod(lambda s: FakeService))
+    monkeypatch.setattr(handlers, "load_full_cdm", lambda *a: None)
+
+    with pytest.raises(_Captured) as exc:
+        download_manager.perform_download("job-1", "EXAMPLE1", "t1", {"quality": "1080p", "cdm_only": True})
+
+    assert exc.value.args == ([1080], [1080], True)