mirror of
https://github.com/unshackle-dl/unshackle.git
synced 2026-11-22 00:45:10 +00:00
refactor(core)!: drop leading underscores from internal definitions
Renames 314 defs and 41 module/class-level constants. Keeps 11 names underscored where the stripped form collides in scope, plus 5.5.0 shims for the three symbols external service repos call.
This commit is contained in:
@@ -101,11 +101,11 @@ REAL_WORLD_AUDIO_LANGS = [
|
||||
]
|
||||
|
||||
|
||||
def _mk(*tags):
|
||||
def mk(*tags):
|
||||
return [Audio("https://x", language=t, id_=t) for t in tags]
|
||||
|
||||
|
||||
def _select(tags, pool, exact=True):
|
||||
def select(tags, pool, exact=True):
|
||||
return [(t.id, str(t.language)) for t in Tracks.by_language(pool, tags, per_language=1, exact_match=exact)]
|
||||
|
||||
|
||||
@@ -124,56 +124,56 @@ def test_distinct_pairs_are_not_distance_zero(base, reg):
|
||||
@pytest.mark.parametrize("base,reg", COLLAPSING_PAIRS)
|
||||
def test_exact_lang_selects_distinct_collapsing_variants(base, reg):
|
||||
# Both tracks present + both tags requested: each tag must route to its own track.
|
||||
assert _select([base, reg], _mk(base, reg)) == [(base, base), (reg, reg)]
|
||||
assert select([base, reg], mk(base, reg)) == [(base, base), (reg, reg)]
|
||||
|
||||
|
||||
@pytest.mark.parametrize("base,reg", DISTINCT_PAIRS)
|
||||
def test_exact_lang_distinct_regionals_still_work(base, reg):
|
||||
assert _select([base, reg], _mk(base, reg)) == [(base, base), (reg, reg)]
|
||||
assert select([base, reg], mk(base, reg)) == [(base, base), (reg, reg)]
|
||||
|
||||
|
||||
def test_exact_lang_lenient_base_to_regional_fallback():
|
||||
# Only the regional present; a base request must still find it when CLDR rates them equal.
|
||||
assert _select(["en"], _mk("en-US")) == [("en-US", "en-US")]
|
||||
assert select(["en"], mk("en-US")) == [("en-US", "en-US")]
|
||||
# Alias with no string-equal track must still resolve (zh -> cmn).
|
||||
assert _select(["zh"], _mk("cmn")) == [("cmn", "cmn")]
|
||||
assert select(["zh"], mk("cmn")) == [("cmn", "cmn")]
|
||||
|
||||
|
||||
def test_exact_lang_stays_strict_for_nonzero_distance():
|
||||
# `es` does NOT accept `es-419` in exact mode (distance 5), but fuzzy mode does.
|
||||
assert _select(["es"], _mk("es-419")) == []
|
||||
assert _select(["es"], _mk("es-419"), exact=False) == [("es-419", "es-419")]
|
||||
assert select(["es"], mk("es-419")) == []
|
||||
assert select(["es"], mk("es-419"), exact=False) == [("es-419", "es-419")]
|
||||
|
||||
|
||||
@pytest.mark.parametrize("base,reg", COLLAPSING_PAIRS)
|
||||
def test_overlapping_tags_never_duplicate_in_fuzzy_mode(base, reg):
|
||||
# Non-exact still collapses base/regional, but must dedupe rather than return a track twice.
|
||||
selected = Tracks.by_language(_mk(base, reg), [base, reg], per_language=1, exact_match=False)
|
||||
selected = Tracks.by_language(mk(base, reg), [base, reg], per_language=1, exact_match=False)
|
||||
assert len({t.id for t in selected}) == len(selected)
|
||||
|
||||
|
||||
def test_exact_lang_three_way_base_and_two_regionals():
|
||||
# fr (base, dist 0 to fr-FR) + fr-FR + fr-CA (dist 4): all three must resolve distinctly.
|
||||
assert _select(["fr", "fr-FR", "fr-CA"], _mk("fr", "fr-FR", "fr-CA")) == [
|
||||
assert select(["fr", "fr-FR", "fr-CA"], mk("fr", "fr-FR", "fr-CA")) == [
|
||||
("fr", "fr"),
|
||||
("fr-FR", "fr-FR"),
|
||||
("fr-CA", "fr-CA"),
|
||||
]
|
||||
# Base request with no bare-tag track falls back to its paradigm regional, without stealing
|
||||
# the sibling regional (fr -> fr-FR, not fr-CA).
|
||||
assert _select(["fr", "fr-CA"], _mk("fr-FR", "fr-CA")) == [("fr-FR", "fr-FR"), ("fr-CA", "fr-CA")]
|
||||
assert select(["fr", "fr-CA"], mk("fr-FR", "fr-CA")) == [("fr-FR", "fr-FR"), ("fr-CA", "fr-CA")]
|
||||
|
||||
|
||||
@pytest.mark.parametrize("tag", REAL_WORLD_AUDIO_LANGS)
|
||||
def test_full_language_set_each_tag_resolves_to_itself(tag):
|
||||
# Against a full real-world language pool, every exact request must return its own track, so
|
||||
# that no tag captures another's: ar-EG must resolve to ar-EG, never to ar.
|
||||
pool = _mk(*REAL_WORLD_AUDIO_LANGS)
|
||||
assert _select([tag], pool) == [(tag, tag)]
|
||||
pool = mk(*REAL_WORLD_AUDIO_LANGS)
|
||||
assert select([tag], pool) == [(tag, tag)]
|
||||
|
||||
|
||||
def test_full_language_set_selects_every_track_once():
|
||||
pool = _mk(*REAL_WORLD_AUDIO_LANGS)
|
||||
pool = mk(*REAL_WORLD_AUDIO_LANGS)
|
||||
selected = Tracks.by_language(pool, REAL_WORLD_AUDIO_LANGS, per_language=1, exact_match=True)
|
||||
assert len(selected) == len(REAL_WORLD_AUDIO_LANGS)
|
||||
assert {t.id for t in selected} == set(REAL_WORLD_AUDIO_LANGS)
|
||||
|
||||
Reference in New Issue
Block a user