kenzuya/unshackle
1
0
Fork 2
mirror of https://github.com/unshackle-dl/unshackle.git synced 2026-05-16 21:59:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(proxies/nordvpn): use *.proxy.nordvpn.com for HTTPS proxy

Browse Source 
NordVPN's HTTPS proxy endpoints now serve a certificate valid only for *.proxy.nordvpn.com. Connecting to the legacy <server>.nordvpn.com:89 hostname fails with SSLCertVerificationError (hostname mismatch).

Rewrite direct queries, server_map entries, and API-returned hostnames to the proxy subdomain so cert validation succeeds.
This commit is contained in:
imSp4rky
2026-05-11 09:55:48 -06:00
parent 9e4fdcdcd8
commit 20c15f761b
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
unshackle/core/proxies/nordvpn.py
View File

@@ -64,7 +64,7 @@ class NordVPN(Proxy):
if re.match(r"^[a-z]{2}\d+$", query): if re.match(r"^[a-z]{2}\d+$", query):
# country and nordvpn server id, e.g., us1, fr1234 # country and nordvpn server id, e.g., us1, fr1234
hostname = f"{query}.nordvpn.com" hostname = f"{query}.proxy.nordvpn.com"
else: else:
if query.isdigit(): if query.isdigit():
# country id # country id
@@ -86,7 +86,7 @@ class NordVPN(Proxy):
if server_mapping: if server_mapping:
# country was set to a specific server ID in config # country was set to a specific server ID in config
hostname = f"{country['code'].lower()}{server_mapping}.nordvpn.com" hostname = f"{country['code'].lower()}{server_mapping}.proxy.nordvpn.com"
else: else:
# get the recommended server ID # get the recommended server ID
recommended_servers = self.get_recommended_servers(country["id"]) recommended_servers = self.get_recommended_servers(country["id"])
@@ -113,6 +113,9 @@ class NordVPN(Proxy):
# NordVPN uses the alpha2 of 'GB' in API responses, but 'UK' in the hostname # NordVPN uses the alpha2 of 'GB' in API responses, but 'UK' in the hostname
hostname = f"gb{hostname[2:]}" hostname = f"gb{hostname[2:]}"
if hostname.endswith(".nordvpn.com") and not hostname.endswith(".proxy.nordvpn.com"):
hostname = hostname[: -len(".nordvpn.com")] + ".proxy.nordvpn.com"
return f"https://{self.username}:{self.password}@{hostname}:89" return f"https://{self.username}:{self.password}@{hostname}:89"
def get_country(self, by_id: Optional[int] = None, by_code: Optional[str] = None) -> Optional[dict]: def get_country(self, by_id: Optional[int] = None, by_code: Optional[str] = None) -> Optional[dict]: